Changyu Bi

Hi - thanks for debugging this issue and submitting a fix. I think I understand the cause of the "deadlock" situation, which is caused by the group commit of manifest...

RocksDB lite was deprecated in version 8.0 (Feb 2023).

> Hi @liyichao, thanks for reporting and trying out DeleteRange(). I guess this is the "risk" use case you described in a previous comment. I assume this latency increase is...

Re-open the issue so we remember to add some safeguard before it's supported. The above test passes now. But if DeleteRange() and row key is from the same SST file,...

> PR #12230 did not fix the issue, we applied the PR to our branch, the issue still exists:  > > The gray text is empty MemTable. Are they...

> LGTM - with some minor notes Thanks for the quick review.

The second approach sounds cleaner since it does not require consecutive sequence numbers in consecutive WALs. We may still need to put some special value in the marker record to...

> It feels like we would need a new record type at the start anyways to indicate that. Makes sense. For the dummy record, if it contains the size of...

We don't use direct I/O for WAL files: see https://github.com/facebook/rocksdb/wiki/Direct-IO and https://github.com/facebook/rocksdb/issues/12136. > I noticed direct io WAL writes do not do metadata sync even when I have DBOptions.use_fsync =...

Thanks @Orvid, tests are passing on our end now.