shorah icon indicating copy to clipboard operation
shorah copied to clipboard

results not reproducible even random seed '-S' is set

Open jeffchen2000 opened this issue 6 years ago • 2 comments

when I run shorah.py, I set '-S 100', but the results are not reproducible, (I downloaded and installed shorah in Nov-2018)

jeffchen2000 avatar Dec 08 '18 00:12 jeffchen2000

  • How much variations are you seeing ?
  • Which version are you using ?

In older versions, there was a bug causing memory corruption. This is fixed in version v1.1.3.

  • This would have caused completely random-looking results in a few corner cases.

The computation of results is dependent on the math library and is thus implementation-dependent. Running it on a Mac laptop and on a Linux HPC cluster can yield slightly different results (and the diri_sampler step is computed in log-space so its typically affected by this type of rounding implementation differences).

  • This would have cause results which are roughly the same, save for fraction-of-% difference in the scores (and probably different ordering in the CSV file).

We're seeing the same kind of difference after having swapped the math engines between Shorah 1.x and upcoming Shorah 2.0

DrYak avatar Feb 15 '19 10:02 DrYak

We will release previews of ShoRAH 2.x shortly. Please note that in the newer version, -R is now used for seed and -S is for the sigma parameter when analysing strand bias.

It has a different random engine than ShoRAH 1.x, so even by user the same seed parameters, the result will differ.

DrYak avatar Apr 01 '20 17:04 DrYak