jcommander icon indicating copy to clipboard operation
jcommander copied to clipboard

Implementation for issue https://github.com/cbeust/jcommander/issues/395

Open dibog opened this issue 7 years ago • 2 comments

Hi,

in the following pull request you can find my implementation for the feature I described within issue https://github.com/cbeust/jcommander/issues/395.

It contains:

  • the change it self
  • test cases (as I'm unfamilier with TestNG they might be not fully correct)
  • I added to your documentation, but as I'm not familar with gradle or koblat I couldn't check it (I'm using maven)

Best regards, Dieter

dibog avatar Sep 09 '17 22:09 dibog

I'm working on a windows system and there I couldn't get the project to run or test run as I'm no aware how to do that with Unix only scripts. My test class run fine within IntelliJ though. The errors which occured seems not to stem from my changes, but from a defect configuration. If a pom would be provided I could check what exactly went wrong.

dibog avatar Sep 10 '17 17:09 dibog

Are you still interested in this contribution?

mkarg avatar Dec 21 '23 16:12 mkarg

@dibog Kindly requesting your response! :-)

mkarg avatar Jul 06 '24 16:07 mkarg

@mkarg Hi Markus,

since some years I switch to Kotlin and am using there the very nice https://ajalt.github.io/clikt/. So I have no more interest in this change request, but in case you want to use my merge request, feel free to use it.

Best regards, Dieter

dibog avatar Jul 07 '24 07:07 dibog

Thank you for your quick answer, Dieter. In fact I do not see the benefit of valueOf for the reason outlined in https://github.com/cbeust/jcommander/issues/395#issuecomment-337334608. Anyways, thank you for contributing to JCommander. :-)

mkarg avatar Jul 07 '24 09:07 mkarg