fuser icon indicating copy to clipboard operation
fuser copied to clipboard

`Reply` trait is public but not meaningfully usable

Open FeldrinH opened this issue 1 month ago • 2 comments

Currently the Reply trait is public, but it cannot be used in any meaningful way, because its only method requires an instance of ReplySender which is private and only has private implementors.

What is the purpose of having Reply in the public API? Looking at the code it seems to be an internal implementation trait that should not be exposed to users.

FeldrinH avatar Nov 14 '25 09:11 FeldrinH

Same question about ReplyDirectory::new and ReplyDirectoryPlus::new.

FeldrinH avatar Nov 14 '25 10:11 FeldrinH

A lot of the code in fuser is from a previous maintainer. The Reply trait included. Feel free to submit PRs that clean up parts of the public API, which obviously do not make sense

cberner avatar Nov 15 '25 04:11 cberner