Christopher Berner

Results 118 comments of Christopher Berner

Np! Can you give the linked PR a try?

@casey yep, that's how I'm thinking of implementing it to start. I'm going to try and make it flexible enough that if I end up making `RedbKey` & `RedbValue` public...

I think this is probably blocked on https://github.com/rust-lang/rust/issues/76560 To ensure that the alignment is checked at compile time, I need code like this to work: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=bb5f314b6aa0e29f26566fb7d715d7eb and I don't see...

https://github.com/cberner/redb/pull/490 adds alignment to the file format, so that it can be supported in the future without requiring a file format upgrade

I did some work on this in the [alignment](https://github.com/cberner/redb/tree/alignment) branch. The next step from that branch is changing `RedbValue::from_bytes()` to take an `AlignedSlice` However, I'm not sure this is going...

ya, I looked into that solution briefly, and good to see that it seems to work. However, I think it's probably not going to be a good fit for the...

@dignifiedquire I tried that out, and unfortunately it's not going to work well. The const generic parameter would leak out into the whole API, requiring things like `const MY_TABLE: TableDefinition...

I added an example showing one way to workaround this. Please re-open if you find a way around the Rust associated const generic issue though! I do think this would...

Ya, that's definitely possible, but I don't want to implement it that way because it would be too easy to introduce bugs

1) it could, although you were the one that asked for passing both refs and owned values ;) https://github.com/cberner/redb/issues/448 2) hmm, I'll take a look. I thought I had worked...