Beni Cherniavsky-Paskin

Results 502 comments of Beni Cherniavsky-Paskin

# Overview of directions Opened separate issues for several proposed directions, for easier discussion. (cc @stiller-leser @kuahyeow) - "Union" client as discussed here, with methods from many groups. The main...

Is this really controlling what #512 describes? https://github.com/httprb/http/blob/v4.4.1/lib/http/connection.rb#L184-L188 https://github.com/httprb/http/blob/v4.4.1/lib/http/client.rb#L113-L116 seems it affects Ruby-level logic closing connection on inactivity, not TCP-level keepalive? Generally, I'm not against exposing more options :+1:. We...

ref equivalent python lib issue https://github.com/kubernetes-client/python/issues/745. - [ ] the list kind is not guaranteed to be singular kind + "List" :frowning_face: - relation between the two not available in...

https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/284 confirms `.discover` raises if whole api group doesn't exist. Moving discussion from there: > @cben there's probably a reason for why it is the way it is but what...

About changing `.new`: IMHO not worth backward compatibility price. We already have `.discover`. Could add a factory method that does immediate discovery like `Kubeclient::Client.connect` but not even sure it's worth...

Hmm, we do have unit tests for `respond_to?` working: https://github.com/abonas/kubeclient/blob/master/test/test_missing_methods.rb (It even triggers immediate discovery if not done yet. It's a bit surprising compared to "constructor doesn't do any network...

> That's fair, so if discovery fails we should leave client.discovered as false so it would be retried? Yes, this already happens. But then, whether the original response was assumed...

## 1. Mutable `Client` or external mutable object holding credentials? Would a first step of making `Client` mutable, at least for auth_options, be helpful? No. Presently you need separate `Client`...

## 2. Will the current way users construct `Client` by passing in `auth_options: config.context.auth_options` etc. need to change? Probably. We might be able to smuggle an auth object instead of...

Kubernetes plans to change service account tokens to short-lived: https://github.com/kubernetes/kubernetes/issues/70679 This even simple in-cluster config will require on-the fly auth updates.