Beni Cherniavsky-Paskin
Beni Cherniavsky-Paskin
Thanks for the POC!!, sorry for not responding. Due to extra dependencies on websocket-client-simple -> eventmachine, I wasn't sure it's great to add this to kubeclient itself. We already use...
Funnily enough, this was _the_ motivating case for the original change #355, but all the pretty tables where I listed it as changed there were based on testing `underscore_entity` and...
Thanks for looking into this. Neat test! Hmm, I'd like to play with this too. We don't really need `finish` to close it immediately, just "soon" (this was already the...
Faraday documents `close` as: > # Close any persistent connections. The adapter should still be usable > # after calling close. -- https://github.com/lostisland/faraday/blob/e41668ee591735a8be65fd739cddb7a27518eabd/lib/faraday/adapter.rb#L63-L68 And as far as I can tell,...
No, master uses faraday where we previously used `rest-client`, but watching still uses `http`. It'd great to converge them, although not strictly a release blocker.
Turns out `on_data` response streaming is presently [supported by only 2 faraday adapters](https://github.com/lostisland/awesome-faraday/#adapters) — the basic Net::HTTP and httpx. But it would be sad to generally support only these 2....
Nothing prevents, your analysis is right.
Closing, assuming #461 fixed this.
reopening: - [ ] the fix only covered `certificate-authority`, but `certificate-authority-data` would still have the bug. - [x] according to new test I added for this in #552, ~~the fix...
interesting, in https://github.com/lostisland/faraday/issues/371 (opened on faraday but actaully not specific to faraday at all) people had possibly related findings :eyes: - > Also, in ca_file you have to have all...