Beni Cherniavsky-Paskin comments

Results 502 comments of


                                            Beni Cherniavsky-Paskin

Expose {create,delete,...}_entity methods to manipulate objects of dynamic kind

https://github.com/abonas/kubeclient/pull/241#issuecomment-296431061 points out that among many other things #241 tried to, in offered better names and possibly better interface: > client.create(resource|json) > client.update(resource|json) > client.patch(resource|json) > client.delete(resource|json) where the passed...

Expose {create,delete,...}_entity methods to manipulate objects of dynamic kind

@abonas you've previously objected to #241 adding "more than one way of doing the same thing". Would love to hear your thoughts as I'm pushing for a variant of same...

Expose {create,delete,...}_entity methods to manipulate objects of dynamic kind

> `client.patch(resource|json)` For patch, we need a way to choose patch format (#357) — json patch / json merge patch / strategic merge patch (https://kubernetes.io/docs/tasks/run-application/update-api-object-kubectl-patch/). This is not communicated in...

Expose {create,delete,...}_entity methods to manipulate objects of dynamic kind

Right, that decision is clear. Nothing serious, just lack of my time... PRs very welcome :smile: See checkboxes above, there are some questions that I hoped people would have an...

document that watcher stops see #273 and add each_with_retry

Hi, I'm very much aware I owe a review here. Meanwhile I've been trying to figure out how to restart precisely. I recently asked on https://github.com/kubernetes/website/pull/6540#discussion_r160745657 and IIUC the answers,...

document that watcher stops see #273 and add each_with_retry

I quite forgot this PR. Putting resumption aside, there was a good point here that `.each` should distinguish deliberate exit — by `break` / `return` / `.finish` — from forced...

document that watcher stops see #273 and add each_with_retry

Confirmed (3) `{"type": "ERROR", ...}` notices are returned with a 200 status :neutral_face: Turns out it's deliberate in kubernetes per https://github.com/kubernetes/kubernetes/issues/25151: > Either way, for web sockets if we don't...

How to detect 410 Gone in watch response?

You're right that watch does not return actual HTTP error codes, but rather passes a value with error message into the block: ``` pry> kclient.watch_pods(resource_version: "123", as: :parsed) {|n| pp...

How to detect 410 Gone in watch response?

See also previous discussion in your project https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/pull/214

How to detect 410 Gone in watch response?

BTW, `reason` may not always be "Gone". According to this, recent k8s are switching to "Expired": https://github.com/kubernetes/kubernetes/blob/dde6e8e7465468c32642659cb708a5cc922add64/test/e2e/apimachinery/protocol.go#L68-L75 But `code` is 410 for both. (In general, it's better not to depend...