ipmagnet icon indicating copy to clipboard operation
ipmagnet copied to clipboard

Easier setup: auto-detect tracker address if no config file found.

Open fabacab opened this issue 10 years ago • 2 comments

This commit adds a simple configuration file in PHP .ini syntax that makes it easier to configure the tracker address and the database path. The result is that no edits to the source code are required to use this.

fabacab avatar Jan 17 '15 21:01 fabacab

Hi there, and thanks for your contribution! I wanted to let you know I am aware of this PR, I'm just currently too busy to thoroughly review it.

The obvious benefit of reading config from the .ini file would, as you note, be that no edits to the code are needed and it can be excluded from the repository via gitignore.

Then again, I'd like to encourage as many people as possible to actually read the source code to find out what it is doing and confirm for themselves it is not doing anything it shouldn't.

I'll come back to this, and thanks again! :)

cbdevnet avatar Jan 23 '15 14:01 cbdevnet

Cool, take your time. :)

In my humble opinion, people who want to confirm for themselves that the script is not doing anything malicious will read the source regardless of whether or not there is a config file and people who are not going to confirm this for themselves are also not going to do so regardless of the presence of a config file. However, there are also certainly a subset of people who would run this torrent IP checker if there was a config file but would not run this torrent IP checker if there was no way to do so without editing source.

And I would really like to see more people running independent IP checkers. :)

fabacab avatar Jan 23 '15 17:01 fabacab