bradb

Results 52 comments of bradb

Please compare a few of these files and let me know the difference. The code should be identical. --Brad

ptr_intT is a Qhull typedef defined in mem_r.h Please submit a new pull request to change ptr_intT to intptr_t for C99+ compilers. Is another 'include' required for intptr_t? typedef intptr_t...

-Wredundant-decls should distinguish function redeclarations from variable redeclarations. Variable redeclarations change the code and should be avoided. Function redeclarations have no effect as far as I know. Will leave open...

POSITION_INDEPENDENT_CODE is set for qhull_CPP (#47). Is another change needed? fPIC is tricky to get right. It apparently needs matching settings in multiple places. See the discussion and changes made...

For a worked out example of the ccp interface, see http://www.qhull.org/src/user_eg3/user_eg3.cpp I'm sorry for the struggle with QhullUser. The cpp interface needs full C++ documentation with worked out examples. Hopefully,...

Thanks for your note and good comments. I'll update the documentation in the next release. --Brad

Which files have different checksums? Perhaps there's a misplaced use of CRLF.

Closing. qset.h is low level code. Fixing the MSVC warnings is likely to have unintended consequences.

I agree with spacelm's comment that CMAKE_POSITION_INDEPENDENT_CODE should be the user's responsibility. Is it (1) better to leave CMakeLists.txt as is or (2) revert #47 and thus remove 'POSITION_INDEPENDENT_CODE' from...

The change log is in the src directory. See the Wiki for changes https://github.com/qhull/qhull/blob/master/src/Changes.txt 8.1_alpha1 fixed a message for reporting an error.