php-htmldiff

php-htmldiff copied to clipboard

DOMDocument::loadHTML(): Unexpected end tag : u in Entity

1

Imran-imtiaz48

TableDiff: Unicode characters are silently dropped from diff

2

## Problem description The TableDiff first converts *some* of the string's characters into named entities using `htmlentities()`. The remaining characters are tried to be converted using `iconv()` (might behave differently...

podarcis

Fix Unicode handling in table diff by encoding non-ASCII chars as numeric entities

1

Previously, `TableDiff::createDocumentWithHtml()` attempted to normalize text for `DOMDocument::loadHTML()` by passing it through `htmlentities()` and `iconv('UTF-8', 'ISO-8859-1//IGNORE', ...)`. This caused non-ASCII characters (e.g. emoji, Cyrillic, CJK) that are neither representable HTML...

podarcis

We can accomplish what we need to with Github Actions, at the very least we can run the test suite via github actions

jschroed91