caxlsx Merge axlsx_styler gem into caxlsx

Merge axlsx_styler gem into caxlsx

Open westonganger opened this issue 3 years ago • 1 comments

Merge axlsx_styler gem into caxlsx. As bought up in #167.

This is a first pass on this. We can iterate on it.
A few TODO to be addressed
Test suite needs work (but its passing now with what we from porting from axlsx_styler)

[ ] I have reviewed the guidelines for contributing to this repository.
[ ] I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
[ ] If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
[ ] If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] I added an entry to the changelog.

We need to make some changes to axlsx_styler some short time after a successful release version release of caxlsx

Add a notice on the top of the axlsx_styler readme
Cut a new release which raises an exception if a newer non-supported caxlsx version is used (since the older versions dont restrict caxlsx version heavily).

Sep 30 '22 03:09 westonganger

Thanks for the quick work @westonganger

Sep 30 '22 15:09 straydogstudio

@kiskoza ok I have resolved all the TODO's and addressed your comments.

Oct 13 '22 06:10 westonganger

Seems to me this is more or less ready to go. Any more comments here.

Oct 21 '22 00:10 westonganger

Do we want to release a 3.2.1 version?

Oct 21 '22 11:10 straydogstudio

I have now released v1.2.0 of axlsx_styler which drops support for 3.3.0+ and added a notice at the top of the axlsx_styler readme

Oct 21 '22 17:10 westonganger