helpers icon indicating copy to clipboard operation
helpers copied to clipboard

Helpers task745 propose unit test plan for hopenai.py

Open srinivassaitangudu opened this issue 6 months ago • 1 comments

#745

srinivassaitangudu avatar May 29 '25 18:05 srinivassaitangudu

Thanks, I'll make required changes and let you know.

srinivassaitangudu avatar May 30 '25 15:05 srinivassaitangudu

When you have applied the comments, you should mark it as resolved (there are instructions in the md on all this in how to do a review)

gpsaggese avatar Jun 03 '25 13:06 gpsaggese

I've added lots of TODOs. Let's fix all of them before the next PR.

The major problems are:

  1. You didn't have internalized our coding style
  2. Too much mocking and focus on stuff that doesn't need to be tested

gpsaggese avatar Jun 09 '25 22:06 gpsaggese

@gpsaggese I’ve addressed all the TODOs—let me know if there’s anything I might’ve missed or needs further changes.

srinivassaitangudu avatar Jun 12 '25 18:06 srinivassaitangudu