HelpersTask758_test_aws_ecr1_fails_when_helpers_is_a_submodule

[sandeepthalapanane]

Fixed the #758 with a submodule check and changed the expected command.

[dremdem]

This fix seems not to work for cmamp. Since @sandeepthalapanane doesn't have access to cmamp for testing, @dremdem could you please check and see if the fix can be adapted to work for cmamp as well?

Yes, it doesn't work. I posted a suggestion on how to improve it.

[sandeepthalapanane]

@dremdem In the latest master branch update https://github.com/causify-ai/helpers/commit/bbba40974dec4b06dc9db35e2ac95842819499fe, I noticed the removal of the code that adds the /amp prefix in lib_tasks_docker_release.py. The test file is also updated, so we could close this PR and the issue as it is not needed anymore.

[dremdem]

@dremdem In the latest master branch update bbba409, I noticed the removal of the code that adds the /amp prefix in lib_tasks_docker_release.py. The test file is also updated, so we could close this PR and the issue as it is not needed anymore.

Should we enable the test anyway?
By the way, the test is failing on this branch.
Could you please check why?

[sandeepthalapanane]

@dremdem In the latest master branch update bbba409, I noticed the removal of the code that adds the /amp prefix in lib_tasks_docker_release.py. The test file is also updated, so we could close this PR and the issue as it is not needed anymore.

Should we enable the test anyway? By the way, the test is failing on this branch. Could you please check why?

I just enabled the test. The test failure was from my previous commit, where I made some changes without merging the master branch.

[sandeepthalapanane]

LGTM

@dremdem @sonniki Could you please merge into the master branch?