helpers icon indicating copy to clipboard operation
helpers copied to clipboard

Consider adding step for coverage check in GH

Open gpsaggese opened this issue 7 months ago • 2 comments

How difficult it is to just have a GH check to see if coverage as increased or decreased

gpsaggese avatar May 07 '25 13:05 gpsaggese

We already run a weekly coverage check that flags if overall coverage drops by more than 1%. Adding coverage checks to every pull request feels unnecessary for two main reasons.

  • A single PR typically won’t cause a meaningful shift in overall coverage. And if a PR adds untested code, it’s generally clear from the review itself
  • Running full coverage (including fast, slow, and possibly superslow tests) on every PR would introduce significant compute overhead and slow down the CI pipeline

Shaunak01 avatar May 08 '25 15:05 Shaunak01

All good points, no need to work. But let's leave it open for future reference and mark paused

gpsaggese avatar May 08 '25 21:05 gpsaggese