helpers icon indicating copy to clipboard operation
helpers copied to clipboard

Use scratch space instead of tmp file

Open sonniki opened this issue 9 months ago • 4 comments

In test_amp_doc_formatter.py we are using a temporary file created with tempfile. Instead, we should use our get_scratch_space() and create the file there.

sonniki avatar Mar 03 '25 10:03 sonniki

@sonniki

I ran pytest before and after updating test_amp_doc_formatter.py with get_scratch_space(). Some of the test cases are failing in both cases. Just wanted to know if I need to debug the test cases before I open a PR.

allenmatt10 avatar Mar 28 '25 03:03 allenmatt10

I ran pytest before and after updating test_amp_doc_formatter.py with get_scratch_space(). Some of the test cases are failing in both cases. Just wanted to know if I need to debug the test cases before I open a PR.

The recent build in helpers is green, which means that in our setup those tests currently pass. Of course, they also must pass after you update them. So yes, do some debugging and investigating and try to figure it out.

sonniki avatar Mar 28 '25 10:03 sonniki

@allenmatt10 when you report a failure, pls copy the error so we have more information. I believe there is a section on the doc about repo of an issue, that describes tips & tricks of how to communicate problems.

gpsaggese avatar Mar 28 '25 18:03 gpsaggese

Thank you for the feedback @gpsaggese . I will follow the procedures more clearly.

allenmatt10 avatar Mar 29 '25 04:03 allenmatt10

@sonniki Can this bug be closed now, since the branch is merged?

allenmatt10 avatar Mar 31 '25 18:03 allenmatt10

Closing as done

sonniki avatar Mar 31 '25 18:03 sonniki