causify-ai
Decide what to do about dind installation
FYI @gpsaggese
By default we disable installation of DinD in the dev dockerfile
https://github.com/kaizen-ai/helpers/blob/118f87c592e5801d6fce48542617034f9b9abfbf/devops/docker_build/dev.Dockerfile#L50
but in the repo config it's required by default
https://github.com/kaizen-ai/helpers/blob/118f87c592e5801d6fce48542617034f9b9abfbf/repo_config.py#L102-L131
┆Issue is synchronized with this Asana task by Unito
- I expect that DIND is not really used anywhere, but it seems to be used by default somewhere
elif hserver.is_dev_ck():
ret = True
- See if we can disable it everywhere
- If we can't, we leave as it is and install all the time
I'll be attempting to rebuild the image with DIND because it appears to be needed for tests, we can decide later how we want to deal with this. Long term we should consider if/how we should keep it. It's connected to other important aspects of working with the repo.
https://medium.com/@rashmi160403/securely-running-docker-in-docker-a-comprehensive-guide-cb6efb5b745f#:~:text=Docker%20is%20a%20powerful%20tool,implications%20when%20adopting%20this%20approach.
A clue is given here:
https://github.com/kaizen-ai/helpers/blob/75c07d7b7de28c2f34ea356676691f47295164fa/repo_config.py#L205-L210
The next step is to find why (if) the statement in the comment is true, it was added 7 months ago
https://github.com/cryptokaizen/cmamp/pull/7414/files
Seems we were able to dodge dind as of now by adjusting the repo_config code https://github.com/kaizen-ai/helpers/pull/23/files#r1742402588 but I am not closing the issue yet
I will put an Asana task to resolve this once and for all, we have a giant piece of technical debt related to this - in my opinion we should get rid of dind usage - unless I am shown an example of how it's absolutely necessary.
https://app.asana.com/0/1208280136293554/1208856841287663/f