Pihole plugin v6 compatiblity

[phyzical]

The new versions of pihole are no longer compatible with the widget,, they are enforcing the rest api, they use new auth system via sessions that must be expired ect.

If i get some time in the next few weeks ill take a stab

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[GAS85]

Still active

[phyzical]

yep pr is ready and working, just waiting a review

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[GAS85]

Not stale at all

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[GAS85]

Not stale

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[GAS85]

Nope

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[GAS85]

Nope, please setup bot for a longer grace period.

[HalianElf]

@GAS85 PR was merged 3 weeks ago and should work with v6 now

[GAS85]

Cool! Do you know when will it be released?

[HalianElf]

It's out, just update

[GAS85]

Usually I do update by docker pull, but seems it will not work this time.

[SAS-1]

has something changed with this? It won't display the stats for me and everything is the same as V5 was I never changed it when it broke. Test shows API Success.

[HalianElf]

Usually I do update by docker pull, but seems it will not work this time.

Just restart the container or run the update function from setting, it doesn't need a new container build to update Organizr itself.

has something changed with this? It won't display the stats for me and everything is the same as V5 was I never changed it when it broke. Test shows API Success.

You're still on v5 or you upgraded to v6? The PR didn't keep any backwards compatibility so that needs to be readded back and v5 is broken for the current moment.

[SAS-1]

Sorry I am on V6 I meant that I never changed any of the setup in Organizr from what I had in V5.

[phyzical]

i had a quick look now that its been merged,

stats are coming in but something is causing the render to fail.

ill try to debug whats gone wrong later in the week

[GAS85]

For me it is connected, but no stats are returned at all.

{
    "response": {
        "result": "success",
        "message": null,
        "data": {
            "data": {
                "http://192.168.9.9:18080": {
                    "domains_being_blocked": []
                }
            },
            "options": {
                "combine": true,
                "title": true
            }
        }
    }
}

Just restart the container or run the update function from setting, it doesn't need a new container build to update Organizr itself.

Wow, never thought about it. And it seems not really documented :( How ever, seems I have latest 2.1.3180 now.

[phyzical]

Alright looks like there was a merge conflict that was resolved incorrectly causing it to crash out. put a pr in to resolve

@GAS85 this wouldn't help with your case though it seems as your getting nothing back, my first suggestion is to try

http://192.168.9.9:18080/api/docs/#get-/stats/database/summary this is the endpoint thats used and make sure you get anything

just to rule out bad auth ect

@SAS-1 it should fix it for you though

[GAS85]

Actually yes - there is a data:

docker exec organizr curl "http://192.168.9.9:18080/api/stats/database/summary?from=1672580025&until=1760965352"  -H 'sid: blablabla' -s
{"sum_queries":5263741,"sum_blocked":594537,"percent_blocked":11.294951438903809,"total_clients":2228,"took":9.55165195465088}

Also I check the logs and organizr will call /api/stats/database/top_domains?from=1760879268&until=1760965668&blocked=true&count=1000 and get an 401 Error. Seems it does not work with API Key / Application password. I can only see 200 Status codes if I will provide my user password and disable 2FA, that is not really good.

Also the problem is that "Test connection" button always returns success even on imaginary domains.

[phyzical]

not sure about 2fa, i use a reverse proxy so the services talk to each other in a secure network,

as for the 401 if thats only during curl thats because you dont directly use the api key, but use the api key to generate a session token thats then used to talk to the api. the plugin should handle this part for you but if your testing youll need to hit the api first with the api token to get a sid then use that

~will look at the always returning success but~ addressed was missing a reraise to bubble the error up

[SAS-1]

thanks as soon as it's merged I will test