cauli icon indicating copy to clipboard operation
cauli copied to clipboard

Fixed a bug where table get under the toolbar on scrolling in inspect…

Open kaynewcomer opened this issue 4 years ago • 4 comments

kaynewcomer avatar Mar 24 '20 12:03 kaynewcomer

1 Error
:no_entry_sign: Please include a CHANGELOG entry to credit yourself!
You can find it at /CHANGELOG.md.
4 Warnings
:warning: Are there any changes that should be explained in the README.md?
:warning: Cauli/Florets/Inspector/Record List/InspectorTableViewController.swift#L68 - Variable name should be between 3 and 40 characters long: ‘y’
:warning: Cauli/Florets/Inspector/Record List/InspectorTableViewController.swift#L118 - Top-level declarations should specify Access Control Level keywords explicitly.
:warning: Cauli/Florets/Inspector/Record List/InspectorTableViewController.swift#L131 - Top-level declarations should specify Access Control Level keywords explicitly.

Example CHANGELOG entry

* **feature/improvement/bugfix** Fixed a bug where table get under the toolbar on scrolling in inspect…  
  [#issue_number](https://github.com/cauliframework/cauli/issues/issue_number) by @kaynewcomer  

Trivial PR?

If you think your PR is trivial and neither a CHANGELOG entry nor a README update is necessary, you can add a #trivial to your PR title. The bot will pick that up and will not warn about a missing CHANGELOG or README entry.

Generated by :no_entry_sign: Danger

brototyp-bot avatar Mar 24 '20 12:03 brototyp-bot

Any updates on this here @brototyp @pstued ?

thorstenstark avatar May 22 '20 08:05 thorstenstark

Thanks for the bump! It wasn't on my radar at all. I'll try to check it this weekend.

brototyp avatar May 22 '20 08:05 brototyp

Hi @kaynewcomer and @thorstenstark,

thanks for the PR and the involvement. Unfortunately I can't find the bug this PR is fixing. At least in the example app the development branch works fine.

Can you come up with reproduction steps, if possible things that are different in the example app, so I can reproduce them?

brototyp avatar May 23 '20 13:05 brototyp