userstyles icon indicating copy to clipboard operation
userstyles copied to clipboard

feat(jisho): init

Open Lichthagel opened this issue 1 year ago • 2 comments

🎉 Theme for Jisho.org 🎉

Jisho is a powerful Japanese-English dictionary. It lets you find words, kanji, example sentences and more quickly and easily.

jisho-mocha

💬 Additional Comments 💬

There are some minor inconsistencies/inconveniences. See the included comments.

🗒 Checklist 🗒

  • [x] I have read and followed Catppuccin's submission guidelines.
  • [x] I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • [x] I have ensured that the new directory is in lower-kebab-case.
    • [x] I have followed the template and kept the preprocessor as LESS.
  • [x] I have made sure to update the userstyles.yml file with information about the new userstyle.
  • [x] I have included the following files:
    • [x] catppuccin.user.css - all the CSS for the userstyle, based on the template.
    • [x] preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

Lichthagel avatar Sep 05 '24 10:09 Lichthagel

In this drop down the borders look a bit strange. {B0D5ADE3-9CD3-4B68-9287-140CD1CEABE2}

Beyond that the website looks good

There is some space between those elements: grafik ("Leerraum" means "empty space") They use margin: 0 -2px; to alleviate this, but this is rather inconsistent.

Lichthagel avatar Sep 05 '24 11:09 Lichthagel

grafik

Using display: flex; and removing the margin, removes the gap and also shows the rounded corners, as is likely intended. I did this change in 6772d95 (#1264).

Lichthagel avatar Sep 05 '24 13:09 Lichthagel