toolbox icon indicating copy to clipboard operation
toolbox copied to clipboard

feat: implement hex formatting support

Open rubyowo opened this issue 1 year ago • 1 comments

Closes #164

I'd like to refactor this in the future or sometime else, it's a bit ugly currently.

rubyowo avatar Apr 03 '24 09:04 rubyowo

just dropping an update on this; i've not forgotten about it but i haven't had the time so far to give it the review it deserves. i should be able to work on it in the coming days.

backwardspy avatar Apr 27 '24 08:04 backwardspy

Caught up with @backwardspy on discord, he still plans on coming back to this and would like to have an input in it :+1:

sgoudham avatar May 18 '24 00:05 sgoudham

Speaking broadly, I'm not super into having loads of extra parameters everywhere. Can we somehow centralise this? Also not a fan of the String type being used here, I think at least a type alias to describe what the format represents would be a good improvement at, perhaps a struct that can handle the rendering too, let's see.

nullishamy avatar May 19 '24 20:05 nullishamy

The code has moved to https://github.com/catppuccin/whiskers so I'll be closing this PR. I know @backwardspy is currently improving/iterating on the idea here and will most likely raise another PR himself.

sgoudham avatar Jun 08 '24 23:06 sgoudham

yes indeed! thanks so much for your work on this @rubyowo; i'm building on top of it and you will be co-author of the new commits.

backwardspy avatar Jun 09 '24 08:06 backwardspy