fix(telescope): nvchad and transparency

[Lalit64]

Hi, Here is a small fix to basically make it so that if the telescope.style = "nvchad" and transparent_background = true, then telescope will be opaque and non transparent. I think that if the user explicitly specifies that telescope.style = "nvchad" the user would want the telescope window to be opaque.

[vollowx]

Thanks for your contributions, please also attach a before/after screenshot so that we can review this more easily.

[Lalit64]

With config:

opts = {
  flavour = "mocha",
  transparent_background = true,
  integrations = {
    telescope = {
      enabled = true,
      style = "nvchad",
    },
  },
}

Before:

After:

[comfysage]

i think there should probably be a opts.integrations.telescope.transparent option that should default to the global transparent_background setting. this way users can still maintain the old behavior.

[Lalit64]

@comfysage I think that if the user wants nvchad enabled he would want it to be opaque? If the user doesn't have nvchad enabled and transparency enabled it is still normal and not opaque.

[uncenter]

I agree with @comfysage here; it makes the most sense to me to add an option to allow users who have enabled transparent_background globally to disable transparency specifically for this integration to attain the behavior you refer to.

[Lalit64]

@uncenter style = "nvchad" is the option to disable transparency as of this pr. If it is not defined then it is by default transparent. Why would the user do style = "nvchad" and then want to enable transparency in telescope?

[Lalit64]

Hey can someone check this out?

[vollowx]

NvChad also has its outlined telescope which looks like this

Personally I think we should have 3 styled that names default, nvchad and nvchad_outlined in order to follow NvChad, and I wonder if you could help implement this outlined style since I can't code these days.

[vollowx]

Please check #877