Adding an option to BYO logo for grub/remove logo

[joeljosephreji]

I was thinking of having a logo in the nix configuration directory that could be passed to an option that will put that logo instead of the catppuccin grub logo. Another option which would allow the user to get rid of the logo would be nice as well. Would these be feasible?

[mariovagomarzal]

From what I've been able to see, the Grub module configures the following options:

boot.loader.grub = {
  font = "${theme}/font.pf2";
  splashImage = "${theme}/background.png";
  inherit theme;
};

Here, theme is sources.grub + "/share/grub/themes/catppuccin-${cfg.flavor}-grub-theme". So, for example, for macho that would be this directory of the Grub port. The logo is configured in theme.txt with the following lines:

# Logo image
+ image {
	left = 50%-50
	top = 50%-50
    file = "logo.png"
}

I would say it wouldn't be difficult to apply a patch to the port's source code that replaces the logo.png file with a file specified in a possible new catppuccin.grub.logo option.

Furthermore, this option could accept, in addition to paths, a "none" option or something similar. Then, if this value were specified, a patch could be applied to remove the logo portion from theme.txt.

I don't know if this is a good approach or if its somehow unadvised to apply patches like this.