nix icon indicating copy to clipboard operation
nix copied to clipboard

Document modules that need Allow From Derivation

Open vdbe opened this issue 1 year ago • 5 comments

An extra readme segment that specifies which modules require Allow From Derivation or/and an option to exclude those modules from the global enable option.

vdbe avatar May 14 '24 17:05 vdbe

Willing to implement it myself, just let me know.

vdbe avatar May 14 '24 17:05 vdbe

documenting what modules contain it would be nice. feel free to PR it to our FAQ

regarding excluding them from the global enable option: i can see why this might be a requested feature, but i feel would overcomplicate how we actually implement catppuccin.enable for what's a pretty niche feature. giving a neat list of modules should be good enough for most i'd imagine

getchoo avatar May 21 '24 01:05 getchoo

For the option my idea was to have 1 place (2 nixos and home manager) where you use mkOverride with priority over MkOptionDefault.

This way you don't need to touch mkCatppuccinOpt and can possibly generate the description for documentation instead of a Readme/FAQ segment.

Don't know yet how you would test it so that it is not a best effort option.

Would this implementation be overcomplicated?

vdbe avatar May 21 '24 06:05 vdbe

All the IFD's at the time of writing

    # IFD's
    programs = {
      cava.catppuccin.enable = false;
      foot.catppuccin.enable = false;
      gh-dash.catppuccin.enable = false;
      imv.catppuccin.enable = false;
      kitty.catppuccin.enable = false; # IFD is inside HM
      lazygit.catppuccin.enable = false;
      mpv.catppuccin.enable = false;
      swaylock.catppuccin.enable = false;
      tofi.catppuccin.enable = false;
      zathura.catppuccin.enable = false;
    };
    services = {
      dunst.catppuccin.enable = false;
      mako.catppuccin.enable = false;
    };

vdbe avatar Jun 25 '24 19:06 vdbe

From my experience, nix flake show can fail due to these. Perhaps that could impact how niche we perceive this issue to be.

mightyiam avatar Jul 13 '24 16:07 mightyiam

I just wanted to chime in and mention that the kitty IFD shouldn't be required in upstream anymore. We'll have to switch to setting themeFile instead of theme now though.

https://github.com/nix-community/home-manager/pull/5750

alejandro-angulo avatar Sep 20 '24 19:09 alejandro-angulo

Someone is already working on this, see #337.

vdbe avatar Sep 20 '24 19:09 vdbe

This was meant to be closed by https://github.com/catppuccin/nix/pull/246. Thanks for all the work done here!

getchoo avatar Sep 21 '24 20:09 getchoo