jetbrains icon indicating copy to clipboard operation
jetbrains copied to clipboard

Latte theme: Very low contrast of highlighted search terms in the Search Everywhere window

Open t-bowersox opened this issue 1 year ago • 2 comments

Is there an existing issue outlining your problem?

  • [X] I have searched the existing issues and they do not solve my problem.

Have you followed the instructions in the the pinned issue?

  • [X] I have followed the instructions in the pinned issue and they do not solve my problem.

Describe your problem.

When you have the Latte theme applied, open the "Search Everywhere" window (i.e. pressing Shift twice) and start searching for something.

You should notice that the highlighted matches in the search results have very low contrast and are hard to read.

I checked the colors from the screenshot in the WebAIM contrast checker and the ratio is only 1.41:1. Ideally, the contrast ratio should be 4.5:1.

Attach screenshots.

Screenshot 2024-02-26 at 2 22 21 PM

What IDE(s) are you seeing the problem on?

WebStorm 2023.3.4

Any additional comments?

No response

t-bowersox avatar Feb 26 '24 19:02 t-bowersox

Hey :wave:

Thanks for raising this, I've tried to fix this myself earlier in previous versions and wasn't able to modify it :(

I'll try again later but I distinctly remember the on hover highlight not being in our control.

sgoudham avatar Feb 26 '24 19:02 sgoudham

I looked into this and it is indeed not possible to change the foreground color of SearchMatch. However, if that is a possible change, other background colors would offer a higher contrast ratio:

Color(s) Example Contrast Ratio
Yellow Example 3.05
Rosewater, Pink Example Example 3.02
Click here for the other colors

Colors that have been omitted:

Color(s) Example Contrast Ratio
Sky Example 2.85
Flamingo, Peach Example Example 2.67
Sapphire Example 2.54
Lavender Example 2.50
Green Example 2.38:1
Teal Example 2.13:1
Maroon Example 2.03:1
Blue Example 1.62:1
Mauve, Red (Status Quo) Example Example 1.47:1

On the other hand, this might break contrast ratios for other themes but it took me over 40 minutes to create the table so I'll post this comment anyways.

enidisepic avatar Mar 02 '24 21:03 enidisepic