Charlie Smurthwaite comments

Results 34 comments of


                                            Charlie Smurthwaite

X-Postal-Threat is not set correctly

This is resolved by 1e3622c49abeeb0ca8a7cc1224e84f2fc74cc938

feat: searchable subject

Please can you make a clean pull request from a feature branch? This one brings in a lot of unrelated changes from your `main` branch.

SMTP process hangs when authentication update query is slow

This behaviour is deeply ingrained in the design of the SMTP server. It is single threaded and will not process connections or data from clients while it is running a...

openssl: Support older TLS and DH key

We have discussed this and come to the conclusion that reducing the TLS security level of the whole system should not be necessary. Instead, we have implemented falling back to...

openssl: Support older TLS and DH key

> Falling back is must be in place as by smtp standards, but I still think for speaking with pubic MX is better with at least tls1.0 then with plain....

Mysql2::Error: Data too long for column 'output' at row 1

This should be fixed by a188a161cbdcfd70158b09b53cef622842357c26

Sending error can't modify frozen String

This should be fixed by f0a8aca6e10064fb16daefff9e22dcc20a831868 It's valid for output to be nil, and to_s was supposed to handle this case, but since Ruby 2.7, nil.to_s is frozen, so we...

Fix smtp_server can't use ECDSA certs #1248

Looks good :)

Message Charset / Content-Transfer-Encoding Issue

Thank you for the detailed bug report. This is fixed by 2834e2c37971db9b0b0498e38b382cf1f8ee26eb

Missing attachment when email is not multipart and only contains an attachment

This is definitely a bug. I never thought to look for attachments in a non-multipart email. I will see if we can fix it.