WIP: Use only CATKIN_IGNORE to ignore packages, not COLCON_IGNORE/AMENT_IGNORE

Open janstrohbeck opened this issue 4 years ago • 1 comments

My use case: I have a shared source space in which both ROS1 and ROS2 packages reside (the migration to ROS2 is ongoing). Now I want to build the ROS1 packages using catkin_tools, same as before, and the ROS2 packages using colcon. To do this, I place CATKIN_IGNORE files in the ROS2 packages, and COLCON_IGNORE files in the ROS1 packages.

Problem: catkin_tools/catkin_pkg ignores the ROS1 packages due to an existing COLCON_IGNORE.

I think catkin_tools should ignore ROS1 packages only when there is a CATKIN_IGNORE file present, and not when COLCON_IGNORE/AMENT_IGNORE is present.

This PR depends on a PR in catkin_pkg: https://github.com/ros-infrastructure/catkin_pkg/pull/307

Aug 19 '21 09:08 janstrohbeck

By the way, because I just noticed that I never responded to this PR: I like your suggestion, but we have to wait for the merge of the other pull request, of course.

Feb 22 '22 17:02 timonegk