fx-guice icon indicating copy to clipboard operation
fx-guice copied to clipboard

Use case for ControllerLookup?

Open twalcari opened this issue 10 years ago • 1 comments

Is ControllerLookup still a relevant feature?

As fx-guice is now targeting JavaFX8, and thus supports all features introduced in JavaFX2.2, it also supports getting access to child-controllers as follows:

<VBox fx:controller="com.foo.MainController"> 
...
    <fx:include fx:id="dialog" source="dialog.fxml"/>
...
</VBox>

public class MainController extends Controller { 
    @FXML private Window dialog;
    @FXML private DialogController dialogController;

    ...
}

(source: http://docs.oracle.com/javafx/2/fxml_get_started/whats_new2.htm)

For me, it seems best to remove this class, as - to be useful-, it relies on ParentID, which is broken in JavaFX8.

twalcari avatar Dec 05 '14 09:12 twalcari

ControllerLookup is not a valid feature anymore for JavaFX 8. Are you willing to provide a patch that removes the feature for the upcoming release?

headcr4sh avatar Dec 07 '14 15:12 headcr4sh