Gris Ge

No idea why, but the tox(which is using pip) is failing our CI out of nowhere: https://travis-ci.com/github/nmstate/nmstate/jobs/368543072 The only package missing is `python3-black`. Once I got it into EPEL repo,...

1. Attach bridge to NIC + detach bridge from NIC 2. Attach bridge to bond + detach bridge from bond 3. Attach vlan bridge to NIC + detach vlan bridge...

The unit of these options is `1/100 second`. ```python LinuxBridge.Options.MULTICAST_LAST_MEMBER_INTERVAL, LinuxBridge.Options.MULTICAST_MEMBERSHIP_INTERVAL, LinuxBridge.Options.MULTICAST_QUERIER_INTERVAL, LinuxBridge.Options.MULTICAST_QUERY_RESPONSE_INTERVAL, LinuxBridge.Options.MULTICAST_STARTUP_QUERY_INTERVAL ``` The unit of these options is second: ```python "forward_delay", "ageing_time", "hello_time", "max_age", ``

Need proper handling on bridge port trunk/access mode changing

2

When user switching bridge port between trunk and access mode, should we: * Merge `tag` and other options from current and remove incompatibly options. * User need to define the...

Using bit field in structure is hard to maintain and might be an issue for big endian system. I created some function for bit filed manipulation for nvme kernel. Maybe...

Only treat error as failure.

How about loosen restriction of VPD83 id to support NVMe disks.

12

@joehandzik @tasleson Currently, we are defining the VPD83 ID as VPD83 NAA ID which is not supported by NVMe disks yet. The NVMe disks only expose SCSI VPD83 string ID...

Check PR https://github.com/libstorage/libstoragemgmt/pull/210 for details.