canvas-confetti icon indicating copy to clipboard operation
canvas-confetti copied to clipboard

Expose wobble options

Open kirkegaard opened this issue 3 years ago • 3 comments

In the case of using this library for snow i found that i needed to control the wobble effect. This exposes those two options but keeps the reasonable defaults :)

kirkegaard avatar Nov 23 '21 12:11 kirkegaard

Thanks for your interest. In addition to the comments I left, can you please tell me more about the value added by this MR? The description just says you wanted it?

Yes sorry, i was in a bit of a hurry yesterday :) First of, i really like the library a lot and i we use it quite a bit for various mini interactions. One of the latest use cases was adding snow to our frontpage. For that i wanted a bit more control over the animation like disabling the wobble effect. I saw someone requesting this feature so i tought i would share my code :)

Ive addressed your comments and i hope the changes make a bit more sense this time around :)

kirkegaard avatar Nov 24 '21 14:11 kirkegaard

Do you need anything else from me? :)

kirkegaard avatar Nov 29 '21 14:11 kirkegaard

Waiting for this one 🙏

itayganor avatar Jan 13 '22 18:01 itayganor

This PR is fairly stale, with no recent updates. I am closing it in favor of #202 which added a flat option, similar to disableWobble that was proposed here. I still don't have an understanding of needing to expose fine-tuning of wobble itself. This PR can be resubmitted with the necessary information.

catdad avatar Oct 02 '23 13:10 catdad