Catch2 icon indicating copy to clipboard operation
Catch2 copied to clipboard

Introduce CATCH_CONFIG_PREFIX_MESSAGES to only prefix a few logging related macros.

Open Rijom opened this issue 2 years ago • 3 comments

Description

The macro CATCH_CONFIG_PREFIX_ALL allows to prefix all of catch2's macros with CATCH_. This commit adds some granularity by introducing a new macro: CATCH_CONFIG_PREFIX_MESSAGES. It only prefixes a few debug message macros.

Why? It's rather usual that logging frameworks already use INFO/WARN macros themselves. This allows a user to avoid clashes without having to use the prefix everywhere else.

GitHub Issues

Rijom avatar Oct 07 '22 17:10 Rijom

Codecov Report

Merging #2544 (14b2fee) into devel (6e79e68) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel    #2544      +/-   ##
==========================================
- Coverage   91.20%   91.19%   -0.01%     
==========================================
  Files         192      192              
  Lines        7843     7843              
==========================================
- Hits         7153     7152       -1     
- Misses        690      691       +1     

codecov[bot] avatar Oct 07 '22 18:10 codecov[bot]

Would be nice if you can add it also here: expand_template( expand_template( to ensure the Bazel build does not break.

Vertexwahn avatar Nov 10 '22 12:11 Vertexwahn

Would be nice if you can add it also here: expand_template( expand_template( to ensure the Bazel build does not break.

Like so?

Rijom avatar Dec 23 '22 21:12 Rijom

@horenmar Any comments regarding this PR?

Rijom avatar Mar 06 '23 15:03 Rijom