Nikolay

Results 285 comments of Nikolay

I guess `universal-webpack` is easier in a sense that it doesn't re-implement Webpack but rather is just a Webpack configuration generator. No need to open an issue of `universal-webpack` unless...

@jarzuaga I had a similar thought: as a hacky workaround one could write a basic Node.js script taking path to a file and replacing all CDN_URL substrings in it with...

Does it work without Babel postfix? Webpack didn't support ES6 configs previously.

For me it scrolls to top after I close the modal. `overflow: hidden` is not an option because the page width would change

If I clicked a button and the button was half-shown then after the modal is closed it will return the focus ``` afterClose: function() { focusManager.returnFocus(); focusManager.teardownScopedFocus(); }, ``` https://github.com/reactjs/react-modal/blob/6c03d17e45486d26ec219966af55264b4bcfadf4/lib/components/ModalPortal.js#L112-L115...

The question is: How can I opt-out of `react-modal` restoring focus? (maybe I don't need to do that)

The overflow issue should not be resolved with adding this hack: ``` css .ReactModal__Body--open { // disables page scrolling when modal is presented, // but introduces page width jumps. height:...

Or maybe one can't stop `scroll` propagation. http://stackoverflow.com/questions/5802467/prevent-scrolling-of-parent-element If that's still the case then there's no correct solution. My way (without page width alteration): https://github.com/halt-hammerzeit/react-responsive-ui/blob/master/source/modal.js ``` js import React, {...

@NathanielHill @lbelinsk Doing `ReactModal.setAppElement('body')` is wrong because it sets `aria-hidden` property on `body` while the modal itself is also inside `body`. The point of `appElement` is the modal itself being...

@rwev I don't really see a scenario in which a person would want to somehow use the list of countries corresponding to a specific country calling code. Could you provide...