Nikolay

Results 285 comments of Nikolay

> How closely should the polyfill mirror future releases of React in terms of DEV-mode warnings? I'd say as close as possible. Isn't it the sole purpose of a "polyfill"....

> The purpose of this polyfill, as mentioned in the README, is to enable library authors to avoid forking their libraries for React < 16.3 and >= 16.3. Yeah, and...

It does work when outputting to an `fs` output stream though. So it only works for outputting a file. For outputting to a generic stream it doesn't work.

On the other hand, I can see how it could work with a "recursive" `aria-labelledby`: ![image](https://user-images.githubusercontent.com/477167/154425424-dc9c03ef-dbb4-406f-9c6e-604a5acc47eb.png) ```html Green ... ``` If a screen reader supports recursive `aria-labelledby`, then it would...

Tested in NVDA: it doesn't resolve `aria-labelledby` recursively. So it says: "List Green" (instead of "List Color"), then "List Green. Green List Green 2 of 3".

@kyletsang I can see you've closed this issue but your PR doesn't actually solve it because `` still requires a manually entered `id`. I suggest you reopen it.

I'm too facing it, using Webpack and AWS Lambda. This comment workaround worked (just the `alias/pg-native.js` part): https://github.com/elastic-coders/serverless-webpack/issues/78#issuecomment-271336996

Unrelated: I don't use this library, but looks like the code now has to `waitFor()` the previous function update before running further updates. https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/Lambda.html For example, first the function is...

The short answer is: no, it is inherently thread-unsafe. So it will break in case of using any of the alternative streamed React renderers. http://formidable.com/blog/2017/introducing-rapscallion/

For anyone interested, I refactored my framework today replacing `react-helmet` with my own `@meta()` decorator for setting `` and `` tags: https://github.com/catamphetamine/react-isomorphic-render/blob/master/source/meta.js The approach used is: * only ``s can...