moodle-tool_objectfs icon indicating copy to clipboard operation
moodle-tool_objectfs copied to clipboard

Published 20 hours ago • verified publisher icon catalyst

fixed digitalocean settings issue

Open hohenstaufen opened this issue 5 years ago • 5 comments

digitalocean client was missing some settings that were present in the standard s3 implementation. This fixes #318

hohenstaufen avatar May 12 '20 15:05 hohenstaufen

@hohenstaufen can you please look into why travis is failing?

https://travis-ci.org/github/catalyst/moodle-tool_objectfs/builds/686179273

brendanheywood avatar Jun 05 '20 07:06 brendanheywood

@hohenstaufen can you please look into why travis is failing?

https://travis-ci.org/github/catalyst/moodle-tool_objectfs/builds/686179273

It seems to me that is something not related with the changes, it reports "Fatal error: Node version too old. Require >=14.0.0 <15.0.0, version installed: 8.9.4"

hohenstaufen avatar Jun 05 '20 07:06 hohenstaufen

Hmm, that was already fixed in https://github.com/catalyst/moodle-tool_objectfs/commit/229612aa129ee38f333f55048100f93f00489751

You might need a rebase and a fresh travis run

brendanheywood avatar Jun 05 '20 10:06 brendanheywood

Yeah that fix landed 1 day after your patch, just bad timing

brendanheywood avatar Jun 05 '20 10:06 brendanheywood

Hi Folks,

Any news on this PR? Is there any eta to merge it?

gcavalcante8808 avatar Mar 28 '21 15:03 gcavalcante8808