moodle-local_datacleaner icon indicating copy to clipboard operation
moodle-local_datacleaner copied to clipboard

The settings search doesnt match keywords on the plugin name

Open brendanheywood opened this issue 6 years ago • 3 comments

ie these should all work but do not:

  • [ ] fileconverter_librelambda
  • [ ] fileconverter
  • [ ] librelambda

brendanheywood avatar Aug 27 '19 04:08 brendanheywood

Hi Brendan

I've been doing some testing with the env matrix, but found that not only does it not search on keyword, but it also doesn't find some settings if they haven't been added to the admin tree for some reason (at least I'm assuming this is why as the same settings can't be found via the admin search feature either).

I've added an extra query to find anything not already included in the search and it will now return a search on plugin i.e. fileconverter_librelambda or the config name i.e. conversion_timeout (excluding version).

The original code is clever and checks for headings and text areas which is nice, but the bit I've added is just a straight DB query bolted onto the end to catch anything else that the previous search didn't find, so not sure it's very elegant but it seems to do the job. For your consideration anyway. Sarah

sarahjcotton avatar Oct 20 '23 15:10 sarahjcotton

Also cannot find settings for admin/tool/oauth2 issuers

These details are stored in mdl_oauth2_issuer table

x-iy avatar Dec 15 '23 03:12 x-iy

Anything stored in the db rather than using get_config / set_config, eg mdl_oauth2_issuer, will never work with this and that is annoying but expected

brendanheywood avatar Jan 08 '24 06:01 brendanheywood