moodle-local_datacleaner icon indicating copy to clipboard operation
moodle-local_datacleaner copied to clipboard
verified publisher icon catalyst

Unit tests: scheduled_tasks install.xml does not have correct permissions

Open kristian-94 opened this issue 5 years ago • 3 comments

This recent commit: https://github.com/catalyst/moodle-local_datacleaner/commit/155adac527f0ec17d2a6b368a564e3da1bb49d44

Modified file permissions when it shouldn't have. We need to change this back to 644 for the install.xml file and 755 for the db directory.

kristian-94 avatar Mar 12 '20 04:03 kristian-94

@danmarsden I made a mistake with the last change, and left the file permissions as 777. This looks to be passing travis, when it's green can I merge it?

kristian-94 avatar Mar 12 '20 05:03 kristian-94

Whoops - I should have caught that too!! I've hit that a few times myself too!

danmarsden avatar Mar 12 '20 05:03 danmarsden

Yes, locally you have to change the permissions to let moodle do the save action, but have to remember to change it back after.

kristian-94 avatar Mar 12 '20 05:03 kristian-94