PHP 8.4 test issues

[matthewhilton]

on the MOODLE_500_STABLE branch:

https://github.com/catalyst/moodle-auth_saml2/actions/runs/19154338332/job/54751691449?pr=924

Unknown error type: SimpleSAML\Utils\Crypto::aesEncrypt(): Implicitly marking parameter $secret as nullable is deprecated, the explicit nullable type must be used instead at /home/runner/work/moodle-auth_saml2/moodle-auth_saml2/moodle/auth/saml2/vendor/simplesamlphp/simplesamlphp/src/SimpleSAML/Utils/Crypto.php: 152 in /home/runner/work/moodle-auth_saml2/moodle-auth_saml2/moodle/lib/behat/classes/behat_session_trait.php:939

Unknown error type: SimpleSAML\Module\saml\Error::__construct(): Implicitly marking parameter $cause as nullable is deprecated, the explicit nullable type must be used instead at /home/runner/work/moodle-auth_saml2/moodle-auth_saml2/moodle/auth/saml2/vendor/simplesamlphp/simplesamlphp/modules/saml/src/Error.php: 28 in /home/runner/work/moodle-auth_saml2/moodle-auth_saml2/moodle/lib/behat/classes/behat_session_trait.php:939

[matthewhilton]

Likely, we just need to update the args to be explicit nullable, and then make a .patch to store in the patch files dir

[Peterburnett]

Is this fixed in a later version of SimpleSAMLPHP ? Wouldnt be too bad to fix it there at some point if not, then we dont need to maintain a patch