moodle-auth_saml2 icon indicating copy to clipboard operation
moodle-auth_saml2 copied to clipboard

Published 20 hours ago • verified publisher icon catalyst

Calls to getString/getArray need updating

Open cameron1729 opened this issue 1 year ago • 0 comments

After the lib upgrade, there's still a few calls to getArray that need to be changed to getOptionalArray

e.g.,:

  • https://github.com/catalyst/moodle-auth_saml2/blob/MOODLE_39_STABLE/locallib.php#L150
  • https://github.com/catalyst/moodle-auth_saml2/blob/MOODLE_39_STABLE/locallib.php#L166

And this one confuses me: https://github.com/sarahjcotton/moodle-auth_saml2/blob/MOODLE_39_STABLE/locallib.php#L209 - I don't get why it's called with 3 params.

cameron1729 avatar Oct 06 '23 08:10 cameron1729