moodle-auth_saml2 icon indicating copy to clipboard operation
moodle-auth_saml2 copied to clipboard

Test page need improvements for better support of multiple IdPs.

Open kabalin opened this issue 4 years ago • 1 comments

test.php output is misleading when more than one IdP are in use. I am using tester.php to select IdP. When I select default one, the output is:

  • samltest

When I log out and select another one to login, the output is:

  • samltest1

This has potential to be improved:

  • IdP selector can be added to test.php, this will eliminate the need to provide tester.php file.
  • IdP select items should show display names as well entity IDs, default IdP needs to be pre-selected.
  • When test.php is displaying user data (attributes), it should only display information related to IdP associated with current login session.
  • When there is no single active IdP, test page still not allow to login (or allow via test page only TBD), currently it:
    • test.php shows login link for default IdP, but does not allow to proceed to IdP
    • On tester.php allows to select any available IdP

kabalin avatar May 25 '21 18:05 kabalin

What do you think about changing raw test page to this logic?

  1. Initial page with multiple IdPs image

  2. Logged in state with one of IdPs image

  3. Error on passive authentication attempt. image

kabalin avatar Sep 23 '21 08:09 kabalin