catalyst icon indicating copy to clipboard operation
catalyst copied to clipboard

Update checkpount save_runner interface

Open I8dNLo opened this issue 2 years ago • 1 comments

Updated doc Function has another interface https://github.com/catalyst-team/catalyst/blob/master/catalyst/utils/torch.py#L350

Pull Request FAQ

Description

Related Issue

Type of Change

  • [ ] Examples / docs / tutorials / contributors update
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Improvement (non-breaking change which improves an existing feature)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Checklist

  • [ ] Have you updated tests for the new functionality?
  • [ ] Have you added your new classes/functions to the docs?
  • [ ] Have you updated the CHANGELOG?
  • [ ] Have you run colab minimal CI/CD with latest requirements? Please attach the notebook link.
  • [ ] Have you run colab minimal CI/CD with minimal requirements? Please attach the notebook link.
  • [ ] Have you checked XLA integration? Please attach the notebook link.
  • [ ] Have you checked distributed XLA integration? Please attach the notebook link.

I8dNLo avatar Aug 09 '22 16:08 I8dNLo

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: I8dNLo
:x: Дмитрий Руденко


Дмитрий Руденко seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 09 '22 16:08 CLAassistant

hi, thanks for the PR! could you please review a codestyle issue? looks like we have a minor black update :)

Scitator avatar Aug 12 '22 10:08 Scitator

Sure

I8dNLo avatar Aug 12 '22 12:08 I8dNLo

:warning: The sha of the head commit of this PR conflicts with #1426. Mergify cannot evaluate rules on this PR. :warning:

mergify[bot] avatar Aug 12 '22 14:08 mergify[bot]