Catalyst icon indicating copy to clipboard operation
Catalyst copied to clipboard

inconsistent use of IChangeTokenProvider and ICancellationTokenProvider

Open nshCore opened this issue 6 years ago • 0 comments
trafficstars

We have two classes ChangeTokenProvider and CancellationTokenProvider, that provide wrapped functionality around cancellation tokens, the rationale behind the creation of these was to provide an easier and unified way of testing and mocking cancellation tokens.

Within the code we still use raw Microsoft.Extensions.Primitives.CancellationChangeToken and System.Threading.CancellationTokenSource. These can be replaced with ICancellationTokenProvider and IChangeTokenProvider.

Places seen so far

DeltaVoter PeerQueryTip PeerChallenger

nshCore avatar Sep 30 '19 23:09 nshCore