minisatip icon indicating copy to clipboard operation
minisatip copied to clipboard

Incorrect URL mentioned on status page

Open retrofan1979 opened this issue 2 years ago • 18 comments

The RTSP and HTTP links are mentioned on the status page of minisatip on port 8080. However, the URL's are incorrect for DVB-C.

the following parameters aren't allowed for DVB-C:

  • fe
  • src
  • pol

For example how it should look like: http://192.168.0.10:8080/?freq=378&msys=dvbc&sr=6900&mtype=256qam&pids=0,16,17,18,20,2300,2301,2401,2311

With RTSP link also @ is mentioned and with HTTP link http in address is missing at the beginng of the url.

capture rtsp link

capture http link

retrofan1979 avatar Apr 30 '22 09:04 retrofan1979

Where does it say that fe, src and pol are invalid for DVB-C?

Jalle19 avatar May 02 '22 08:05 Jalle19

Hi, it can be found in the SAT>IP protocol. See query example for DVB-C as well. And fe, src and pol aren't mentioned for DVB-C. Those are for DVB-S.

image

ghost avatar May 02 '22 09:05 ghost

This is a bug in status.html, it should be smarter about adding parameters to the URL.

Jalle19 avatar Aug 01 '22 06:08 Jalle19

fe cannot be removed as it selects which DVB C/T adapter is being used. The other 2 (src, pol) were removed in this PR. cc @Jalle19

catalinii avatar Aug 01 '22 23:08 catalinii

Looks good, at some point we should refactor and clean up some of this logic.

Jalle19 avatar Aug 02 '22 12:08 Jalle19

Great, thanks! If Netstream 4C SAT>IP device is used, fe isn't allowed. It would be nice if the URL in this case also doesn't show fe parameter.

ghost avatar Aug 03 '22 05:08 ghost

"isi" and "plsc" params are missing on multistream HTTP and RTSP links.

image

In addition, alternative audio pids are missing too. URL link only shows the selected audio on Sat-IP client which is playing the channel.

patacalas avatar Aug 03 '22 09:08 patacalas

@retrofan1979 are you talking about the request to the satip server Netstream 4C SAT>IP not involving the URL from minisatip web page ? Or you are talking about copying the URL from web and then sending it to netstream?

catalinii avatar Sep 23 '22 20:09 catalinii

@catalinii yes, the real executed URL isn't displayed on the webpage of minisatip. In case of the Netstream 4C the fe parameter isn't allowed as the device does control itself.

ghost avatar Sep 24 '22 20:09 ghost

@retrofan1979 not sure I got the answer to my questions.

  1. Is the issue with the satip client module in minisatip making the request to Netstream 4C ? [Yes/No]
  2. The URL from the web page includes fe= (as is the case now) causing issues with Netstream 4C ? [Yes/No].
  3. Related to the URL executed is not displayed on minisatip page, what is missing ? Please test https://github.com/catalinii/minisatip/tree/issue_966

catalinii avatar Sep 25 '22 17:09 catalinii

Is the issue with the satip client module in minisatip making the request to Netstream 4C ? [Yes/No] NO The URL from the web page includes fe= (as is the case now) causing issues with Netstream 4C ? [Yes/No]. NO Related to the URL executed is not displayed on minisatip page, what is missing ? Nothing is missing, but the Netstream 4C doesn't support the frontend (fe) parameter, so I expect this parameter will not be displayed at the minisatip page. The same goes for pol and src parameters which are not supported for DVB-C, so in my opinion it may not be displayed in the URL.

ghost avatar Sep 27 '22 16:09 ghost

Can you check how is it now with the latest master?

catalinii avatar Oct 05 '22 00:10 catalinii

looks like the channel names get mixed up when you have multiple delsys like dvbs and dvbc It will crash also with signal 11 after some channel switches between different delsys

9000h avatar Oct 05 '22 07:10 9000h

can you upload the logs? (make debug) also can you provide more info for the "channel names getting mixed up" ?

catalinii avatar Oct 05 '22 21:10 catalinii

here is a sample showing the same channel name for dvb-s and dvb-c which is wrong Unbenannt

9000h avatar Oct 06 '22 11:10 9000h

probably releated to #1000

9000h avatar Oct 08 '22 21:10 9000h

Channel names are fixed

catalinii avatar Oct 09 '22 00:10 catalinii

Can this be closed?

Jalle19 avatar Oct 20 '22 16:10 Jalle19

Can this be closed?

I feel it can be closed. Someone with a DVB-C tuner can check it, please?

lars18th avatar Feb 22 '23 08:02 lars18th