Cataclysm-BN icon indicating copy to clipboard operation
Cataclysm-BN copied to clipboard

"Tried to drain something without any liquid" debugmsg when siphoning from a draining tank

Open olanti-p opened this issue 3 years ago • 3 comments

Tried to drain something without any liquid: <color_c_magenta>|.</color> vehicle tank (60L) (draining) amount: 4 ammo: 0

Backtrace: draining-tank-debug.log

Version: 458e37fa912345fb2514d2e553cd967811f791c6

olanti-p avatar Jul 29 '21 12:07 olanti-p

Could not reproduce.

Drugitechnik avatar Sep 24 '22 18:09 Drugitechnik

The numbers suggest that the tank needs to be significantly damaged and almost-empty, but not completely empty.

It's not easy to set those up without save editing, but it's likely that the bug can happen "in the nature", as non-empty damaged tanks are still common in mapgen vehicles, and as vehicle parts become damaged by ramming and the first response to leaking gas tank is draining it into a non-draining one.

Coolthulhu avatar Sep 24 '22 20:09 Coolthulhu

DDA merged a fix a few days ago for what seems to be this exact issue: https://github.com/CleverRaven/Cataclysm-DDA/pull/61184

olanti-p avatar Sep 24 '22 20:09 olanti-p