Cataclysm-BN icon indicating copy to clipboard operation
Cataclysm-BN copied to clipboard

fix: clang-tidy-wrapper's c++ fixes

Open RobbieNeko opened this issue 4 months ago • 3 comments

Checklist

Required

Purpose of change

Better code practices are nice, and this will hopefully prevent yelling at us by clang in the future.

Describe the solution

Uses the included script by Scarf that acts as a wrapper for clang-tidy

Describe alternatives you've considered

  • Explode
  • Implode
  • Wait for someone else to do it

The script itself seemed to have some bugs (I had to change which flag it was using to tell it to fix the bugs for one, but it also complained about some missing files). However, any improvement is good

Testing

I hope clang-tidy isn't going to break anything, or else we've got some very bad news for the project as a whole.

Additional context

Thanks for RoyalFox asking me to run the script in the first place

Feel free to update the semantic title category as needed

Updated run command for the script:

$ parallel ./build-scripts/clang-tidy-wrapper.sh {} -fix-errors ::: src/*.{c,h}

RobbieNeko avatar Oct 21 '24 21:10 RobbieNeko