Cataclysm-BN icon indicating copy to clipboard operation
Cataclysm-BN copied to clipboard

feat(content): Shocking flag

Open yay855 opened this issue 9 months ago • 3 comments

Added in the shocking json flag, changes to electrical weapons, electrified rapier, tonfa recipe adjustment.

Purpose of change

There was a FLAMING flag which made weapons deal bonus fire damage, but not a SHOCKING flag that made weapons deal bonus electrical damage.

Describe the solution

Added in the SHOCKING flag which is an electrical equivalent to the FLAMING flag. Adjusted electrical weapons to compensate, giving them transformations instead. Made tonfas autolearn, since they're not that amazing and they're basically just clubs with a prong coming out of them.

Describe alternatives you've considered

Testing

I've managed to get it down to only one error! If anyone can help me, please do.

Additional context

Checklist

yay855 avatar Apr 30 '24 03:04 yay855

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

autofix-ci[bot] avatar Apr 30 '24 03:04 autofix-ci[bot]

Hmm. Question: did these need to be hardcoded in at all? I see nothing in this so far that can't be replicated using a mundane transform action?

chaosvolt avatar Apr 30 '24 03:04 chaosvolt

Hmm. Question: did these need to be hardcoded in at all? I see nothing in this so far that can't be replicated using a mundane transform action?

No, no it did not.

yay855 avatar Apr 30 '24 04:04 yay855

Thanks for catching that, Chaos.

yay855 avatar Apr 30 '24 17:04 yay855

How about a shocking pride flag now?

VissValdyr avatar May 01 '24 01:05 VissValdyr