Cataclysm-BN icon indicating copy to clipboard operation
Cataclysm-BN copied to clipboard

feat(port): Resolve cursor positioning interaction with screen readers

Open Zlorthishen opened this issue 9 months ago • 2 comments

Purpose of change

resolves issue https://github.com/cataclysmbnteam/Cataclysm-BN/issues/4533

Ports the following cdda prs

  • https://github.com/CleverRaven/Cataclysm-DDA/pull/45815
  • https://github.com/CleverRaven/Cataclysm-DDA/pull/45951

Describe the solution

Describe alternatives you've considered

Testing

compiles successfully

Additional context

Checklist

Zlorthishen avatar Apr 28 '24 14:04 Zlorthishen

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

autofix-ci[bot] avatar Apr 28 '24 14:04 autofix-ci[bot]

Several notes.

  • It moves a line of code that attempts to center the cursor to begin with, then stops it from being used in SDL tile builds.
    • Why did the original not work? Was it placed in the wrong place?
    • Why does it break tiles? And since it's removed from SDL builds, that means there's no centering there. Will this be an issue?
  • https://github.com/CleverRaven/Cataclysm-DDA/issues/45968#issuecomment-742781837 suggests that the change may also impact blinking zone overlays, can we confirm that this issue does not also appear here in either builds?

KheirFerrum avatar Apr 28 '24 15:04 KheirFerrum

Based on Olanti's advice, Zlorthishen along with me have decided to try to do work on a port of a much more high quality, bigger scope than this, so there is no need to merge this essentially

Kenan2000 avatar Apr 29 '24 01:04 Kenan2000