Cataclysm-BN icon indicating copy to clipboard operation
Cataclysm-BN copied to clipboard

feat(content): Pneumatic Fun Reintegration

Open yay855 opened this issue 9 months ago • 5 comments

For years pneumatic weapons have been locked behind a mod. No more!

Purpose of change

Pneumatic weapons served as a useful earlygame ranged option, but were obsoleted way back when. The Pneumatic Fun mod reimplemented them, but these weapons are useful earlygame ranged options.

Describe the solution

The contents of the Pneumatic Fun mod, barring the meme-y pebble ammos, have been reimplimented, with some minor adjustments to damage, range, and ammo recovery for the nail weapons and ammos.

Describe alternatives you've considered

Testing

Additional context

Checklist

yay855 avatar Apr 28 '24 12:04 yay855

Two of the rail rifles are specifying the same sound value as they're copying from, one of the nail guns is specifying the same skill as its copyfrom, and the nailmag is having some general issues with not being a magazine and apparently circular dependencies.

RobbieNeko avatar Apr 28 '24 15:04 RobbieNeko

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

autofix-ci[bot] avatar Apr 28 '24 15:04 autofix-ci[bot]

There we go, that's much better. Now the tests shouldn't yell at you ^-^

RobbieNeko avatar Apr 28 '24 15:04 RobbieNeko

On another note, nice to see another very active jsoner! Good job @yay855

VissValdyr avatar Apr 28 '24 16:04 VissValdyr

Is it supposed to basically undo the changes made in #2718?

Whoops, my bad! I'll undo that undo.

yay855 avatar Apr 28 '24 16:04 yay855