broken graphical overmap display alignment after mutable overmap

[scarf005]

Describe the bug

after #3520, many graphical tiles which changes its appearance based on its neighbors no longer rotate properly. this bug itself was found while testing #3657.

Steps To Reproduce

play tiles with graphical overmap enabled.

Screenshots

shipwreck

fishing pond and river

Versions and configuration

• OS: Linux
  • OS Version: Distributor ID: Ubuntu; Description: Ubuntu 23.10; Release: 23.10; Codename: mantic;
• Game Version: d56fab08892d [64-bit]
• Graphics Version: Tiles
• LAPI Version: 1
• Game Language: English [en_US]
• Mods loaded: [ Bright Nights [bn], Disable NPC Needs [no_npc_food], Simplified Nutrition [novitamins], No Rail Stations [No_Rail_Stations], Elevated bridges [elevated_bridges], Prevent Zombie Revivication [no_reviving_zombies], Limit Fungal Growth [limit_fungal_growth] ]

Additional context

cc @Vollch

[Vollch]

Can't reproduce on:

• OS: Windows
  • OS Version: 10.0.19045.3570 (22H2)
• Game Version: 360263dff36 [64-bit]
• Graphics Version: Tiles
• LAPI Version: 1
• Game Language: English [en_US]
• Mods loaded: [ Bright Nights [bn], Disable NPC Needs [no_npc_food], Simplified Nutrition [novitamins], No Rail Stations [No_Rail_Stations], Elevated bridges [elevated_bridges], Prevent Zombie Revivication [no_reviving_zombies], Limit Fungal Growth [limit_fungal_growth] ]

Can someone else check it?

[olanti-p]

@scarf005 Are you using Undead People version from Boophis? It does have this bug with the river banks and wrong rotations.

[Vollch]

Looks like there is something fishy after all. (But shipwrecks, fishing pons, and shores still works correctly for me) At first i stumbled on misaligned public pond, and then after checking few more special also noted same problem with botanical garden, and football field. All three debug spawned with single rotation. Looks like some tiles rotates clockwise, while other counterclockwise, and that might be what causes this mess. Can it be somehow related to https://github.com/cataclysmbnteam/Cataclysm-BN/pull/1762?

Edit: I tried to find what exactly caused it, and turns out it worked like that since forever. Checked few builds all the way down to BN 0.1 and they all had same messy rotations of botanical garden.

[scarf005]

Are you using Undead People version from Boophis? It does have this bug with the river banks and wrong rotations.

for clarification, i've been using base game.

[scarf005]

after purging and copying repo's gfx, misalignment with evac center is solved, however the issue with public pond persists.