Cataclysm-BN icon indicating copy to clipboard operation
Cataclysm-BN copied to clipboard

Sealed containers stay sealed when emptied

Open YeOldeMiller opened this issue 1 year ago • 5 comments

Describe the bug

Sealed containers do not consistently lose their sealed status on being emptied or consumed from.

Steps To Reproduce

  1. Spawn some preserved food in glass jars or tin cans of any size.
  2. Eat some of the food / empty a container / use up some of the contents through crafting.

Expected behavior:

  • the container loses its sealed status when emptied or when the first portion of its contents is used up

Observed behavior:

  • glass jars retain sealed status no matter what, the name prefix and 'prevents spoiling' quality are both present
  • tin cans become 'opened' when emptied but stay sealed when eaten from or used up for crafting

Screenshots

image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.22621.2428 (22H2)
  • Game Version: d0bdffe [64-bit]
  • Graphics Version: Tiles
  • LAPI Version: 1
  • Game Language: []
  • Mods loaded: [ Bright Nights [bn], Disable NPC Needs [no_npc_food], No Rail Stations [No_Rail_Stations], Elevated bridges [elevated_bridges], Limit Fungal Growth [limit_fungal_growth] ]

Additional context

No response

YeOldeMiller avatar Nov 07 '23 09:11 YeOldeMiller

I have also noticed this on a modded item the birch jug. It cannot be filled from a environmental water source but can be the target of crafted liquids and drank from. I suspect its being seen as constantly sealed.

Treah avatar Nov 08 '23 04:11 Treah

Doesn't look fixed to me: image This is 47ee09b

UPD: tins and jars now do seem to get unsealed when emptied or eaten from, but in the latter case, it should happen on first change, not when fully emptied. When used up through crafting, still doesn't work at all.

YeOldeMiller avatar Nov 11 '23 19:11 YeOldeMiller

Still getting the same behavior in 0f8ea67 when items from containers are used for crafting.

image

YeOldeMiller avatar Nov 18 '23 07:11 YeOldeMiller

Another detail, most likely related to the main issue: when partially eating from a container located in an adjacent tile (not in inventory), a log message appears: You leave the empty %container_name%, even if said container is not empty:

image

YeOldeMiller avatar Nov 29 '23 06:11 YeOldeMiller