Cataclysm-BN icon indicating copy to clipboard operation
Cataclysm-BN copied to clipboard

[DDA Port] Fix black lines and misaligned rotated sprites on Windows

Open olanti-p opened this issue 2 years ago • 0 comments

Summary

SUMMARY: Bugfixes "[DDA Port] Fix black lines and misaligned rotated sprites on Windows"

Purpose of change

Fix black lines and misaligned rotated sprites on Windows. Example cases: image image

Describe the solution

Cherry-pick https://github.com/CleverRaven/Cataclysm-DDA/pull/45524, which removes the offset. From the discussion in original PR, that most likely was a workaround for some SDL bug which appears to have been fixed since (our mingw releases use SDL 2.0.14 at the moment and msvc - SDL 2.0.20).

Testing

Done on Windows 10. Downloaded latest release, then compared with the fixed releases built by GA on my own fork: https://github.com/cataclysmbnteam/Cataclysm-BN/releases/tag/cbn-experimental-2022-08-06-2156 Before: tiles are misaligned with direct3d11/software/opengl renderers in both msvc and mingw x64 releases. After: tiles are drawn properly with the aforementioned renderers. image image

olanti-p avatar Aug 06 '22 22:08 olanti-p